[BUGFIX] Corrections sur le blocage de langue de certif pour les pix-plus - #17420
Merged
Conversation
|
Choisir les applications à déployer :
Important N'oubliez pas de déployer l'API pour pouvoir accéder aux fronts et/ou à l’API MaDDo. |
lgoubin
marked this pull request as draft
September 7, 2026 15:29
lgoubin
marked this pull request as ready for review
September 9, 2026 09:05
lgoubin
changed the title
yaf
approved these changes
Sep 10, 2026
lgoubin
force-pushed
the
tech-fix-e2e-certif-language-dropdown
branch
from
September 10, 2026 14:01
b83fbc6 to
a2cacec
Compare
yaf
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☀️ Problème
La PR #17398 force la locale fr sur les pix +, or il faudrait forcer la 'fr-FR'. De plus la PR a cassé les tests e2e car elle désactive la dropdown de choix de langue en cas de passage d'un pix +, or le test essaie de cliquer sur cette dropdown.
⛱️ Proposition
En cas de passage Pix plus, forcer la locale 'fr-FR'
Ne pas essayer de cliquer si la dropdown est désactiver
🧴 Remarques
Dans les tests, il n'est pas indispensable de cliquer sur ce menu dans tous les cas, car sauf erreur de ma part, "Français" est le choix par défaut, cependant, on teste donc pourquoi pas vérifier qu'il marche 🤷♀️
🏊 Pour tester
Passer une certif pix plus sur le domain org. Vérifier qu'on se voit proposer 32 questions + vérifier en BDD que la locale est bien fr-FR
sur une certif coeur, pas d'impact.
Lancer les tests e2e (j'ai pas pu les lancer en local)